Skip to content

🐛 Agent should be able to read files in directory now #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2025
Merged

🐛 Agent should be able to read files in directory now #8466

merged 3 commits into from
Oct 8, 2025

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 7, 2025 •
edited
Loading

What do these changes do?

During volume backup, rclone cannot access certain directories and folders. Full permissions have been granted to all users to avoid any file access issues. Since these directories will be removed, it is OK to do so.

NOTE: this comes form production and all UUIDs have been recrated and repalced

Caught unhandled exception.
{
  "exception_type": "<class 'RuntimeError'>",
  "exception_string": "Shell subprocesses yielded nonzero error code 1 for command rclone --config /tmp/rclone_config_e1001433-4d54-4d94-90c4-49069a8fcd72.ini --low-level-retries 3 --retries 3 --transfers 5 --buffer-size 0M --stats 5s --stats-one-line sync /docker/volumes/dyv_1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7_1d1c34f7-e014-4a80-9723-e33776ef9955_ecapskrow_krow_nayvoj_emoh_/_data dst:osparc-simcore-zombie-dy-volume-saves/production-simcore/aab99d34-8bbb-11ef-a023-0242ac1752b8/1d1c34f7-e014-4a80-9723-e33776ef9955/1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7/home_jovyan_work_workspace --verbose --exclude .hidden_do_not_remove --exclude key_values.json
2025/10/07 08:22:10 ERROR : tmp/tmp/tmpzm4ywyxg_kernels: failed to open directory \"tmp/tmp/tmpzm4ywyxg_kernels\": open /docker/volumes/dyv_1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7_1d1c34f7-e014-4a80-9723-e33776ef9955_ecapskrow_krow_nayvoj_emoh_/_data/tmp/tmp/tmpzm4ywyxg_kernels: permission denied
2025/10/07 08:22:10 ERROR : S3 bucket osparc-simcore-zombie-dy-volume-saves path production-simcore/aab99d34-8bbb-11ef-a023-0242ac1752b8/1d1c34f7-e014-4a80-9723-e33776ef9955/1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7/home_jovyan_work_workspace: not deleting files as there were IO errors
2025/10/07 08:22:10 ERROR : S3 bucket osparc-simcore-zombie-dy-volume-saves path production-simcore/aab99d34-8bbb-11ef-a023-0242ac1752b8/1d1c34f7-e014-4a80-9723-e33776ef9955/1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7/home_jovyan_work_workspace: not deleting directories as there were IO errors
2025/10/07 08:22:10 ERROR : Attempt 1/3 failed with 2 errors and: not deleting files as there were IO errors
2025/10/07 08:22:10 ERROR : tmp/tmp/tmpzm4ywyxg_kernels: failed to open directory \"tmp/tmp/tmpzm4ywyxg_kernels\": open /docker/volumes/dyv_1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7_1d1c34f7-e014-4a80-9723-e33776ef9955_ecapskrow_krow_nayvoj_emoh_/_data/tmp/tmp/tmpzm4ywyxg_kernels: permission denied
2025/10/07 08:22:10 ERROR : S3 bucket osparc-simcore-zombie-dy-volume-saves path production-simcore/aab99d34-8bbb-11ef-a023-0242ac1752b8/1d1c34f7-e014-4a80-9723-e33776ef9955/1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7/home_jovyan_work_workspace: not deleting files as there were IO errors
2025/10/07 08:22:10 ERROR : S3 bucket osparc-simcore-zombie-dy-volume-saves path production-simcore/aab99d34-8bbb-11ef-a023-0242ac1752b8/1d1c34f7-e014-4a80-9723-e33776ef9955/1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7/home_jovyan_work_workspace: not deleting directories as there were IO errors
2025/10/07 08:22:10 ERROR : Attempt 2/3 failed with 2 errors and: not deleting files as there were IO errors
2025/10/07 08:22:11 ERROR : tmp/tmp/tmpzm4ywyxg_kernels: failed to open directory \"tmp/tmp/tmpzm4ywyxg_kernels\": open /docker/volumes/dyv_1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7_1d1c34f7-e014-4a80-9723-e33776ef9955_ecapskrow_krow_nayvoj_emoh_/_data/tmp/tmp/tmpzm4ywyxg_kernels: permission denied
2025/10/07 08:22:11 ERROR : S3 bucket osparc-simcore-zombie-dy-volume-saves path production-simcore/aab99d34-8bbb-11ef-a023-0242ac1752b8/1d1c34f7-e014-4a80-9723-e33776ef9955/1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7/home_jovyan_work_workspace: not deleting files as there were IO errors
2025/10/07 08:22:11 ERROR : S3 bucket osparc-simcore-zombie-dy-volume-saves path production-simcore/aab99d34-8bbb-11ef-a023-0242ac1752b8/1d1c34f7-e014-4a80-9723-e33776ef9955/1729491994_395e7498-fa56-46aa-95f6-d18416fa47c7/home_jovyan_work_workspace: not deleting directories as there were IO errors
2025/10/07 08:22:11 ERROR : Attempt 3/3 failed with 2 errors and: not deleting files as there were IO errors
2025/10/07 08:22:11 INFO  :           0 B / 0 B, -, 0 B/s, ETA -
2025/10/07 08:22:11 Failed to sync with 2 errors: last error was: not deleting files as there were IO errors

Related issue/s

How to test

Dev-ops

@GitHK GitHK added this to the Cheops milestone Oct 7, 2025
@GitHK GitHK self-assigned this Oct 7, 2025
@GitHK GitHK added t:maintenance Some planned maintenance work a:agent agent service labels Oct 7, 2025
@GitHK GitHK requested a review from Copilot October 7, 2025 09:13
Copilot AI reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where rclone cannot access certain directories during volume backup by granting full permissions to all users on the source directory.

  • Updates the _ensure_permissions_on_source_dir function to use broader permission settings
  • Changes from granting only read/execute permissions to others to full 777 permissions for all users
  • Adds ownership change to root:root before setting permissions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.55%. Comparing base (d17c117) to head (0ea1dbe).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d17c117) and HEAD (0ea1dbe). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (d17c117) HEAD (0ea1dbe)
unittests 32 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8466       +/-   ##
===========================================
- Coverage   87.63%   66.55%   -21.09%     
===========================================
  Files        1983      788     -1195     
  Lines       77284    35764    -41520     
  Branches     1333      175     -1158     
===========================================
- Hits        67727    23801    -43926     
- Misses       9158    11906     +2748     
+ Partials      399       57      -342
Flag Coverage Δ
integrationtests 64.15% <ø> (+0.04%) ⬆️
unittests 93.54% <100.00%> (+7.20%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.69% <ø> (-8.26%) ⬇️
agent 93.54% <100.00%> (+0.01%) ⬆️
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.11% <ø> (-12.79%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.56%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.07% <ø> (-28.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17c117...0ea1dbe. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK marked this pull request as ready for review October 7, 2025 09:16
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 0ea1dbe.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View

@GitHK GitHK requested a review from matusdrobuliak66 October 7, 2025 09:38
pcrespov
pcrespov approved these changes Oct 7, 2025
View reviewed changes
@GitHK GitHK enabled auto-merge (squash) October 8, 2025 05:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK merged commit ff25190 into ITISFoundation:master Oct 8, 2025
141 of 148 checks passed
@GitHK GitHK deleted the pr-osparc-agent-permissions-bump branch October 8, 2025 06:52
This was referenced Oct 28, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@GitHK GitHK

Labels

a:agent agent service t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

4 participants

@GitHK @giancarloromeo @pcrespov @matusdrobuliak66