Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 8, 2025

What do these changes do?

  • Task button UI's number repositioned
  • Uniformize tasks container
  • Make sure tasks are evaluated not only after reloading but also after re-logging in

TasksUI

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Oct 8, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 8, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Oct 8, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Download large files UX 🎨 [Frontend] Enh: Task button UI Oct 8, 2025
@odeimaiz odeimaiz requested a review from Copilot October 8, 2025 14:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the task button UI by improving positioning, adding immediate initialization, and implementing a display limit for task counts.

  • Updated task button positioning for better visual alignment
  • Added immediate task count evaluation during initialization
  • Implemented "9+" display for task counts exceeding 9

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
services/static-webserver/client/source/class/osparc/task/TasksButton.js Updated positioning values, added initial button update call, and implemented task count display limit
services/static-webserver/client/source/class/osparc/navigation/NavigationBar.js Removed initial visibility exclusion to allow task button to be shown when tasks are present

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2025

🧪 CI Insights

Here's what we observed from your CI run for 985b428.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
system-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz requested a review from Copilot October 8, 2025 15:39
@odeimaiz odeimaiz marked this pull request as ready for review October 8, 2025 15:39
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Task button UI 🎨 [Frontend] Enh: Tasks UI Oct 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

@odeimaiz odeimaiz enabled auto-merge (squash) October 9, 2025 05:43
@odeimaiz odeimaiz merged commit 7e3a178 into ITISFoundation:master Oct 9, 2025
107 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants