Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 9, 2025

What do these changes do?

reported by @pcrespov #8476 (comment)

This PR fixes a bug where the cache wasn't being invalidated after emptying the trash in the dashboard, ensuring that the UI properly reflects the updated state after trash operations.

EmptyTrash

Related issue/s

How to test

Dev-ops

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

@odeimaiz odeimaiz requested a review from Copilot October 9, 2025 12:57
@odeimaiz odeimaiz self-assigned this Oct 9, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the cache wasn't being invalidated after emptying the trash in the dashboard, ensuring that the UI properly reflects the updated state after trash operations.

  • Modified the trash emptied event handler to call invalidateStudies() before reloading resources
  • This ensures cached study data is cleared before fetching fresh data from the server

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@odeimaiz odeimaiz added this to the Cheops milestone Oct 9, 2025
@odeimaiz odeimaiz enabled auto-merge (squash) October 9, 2025 12:59
@odeimaiz odeimaiz merged commit 3319147 into ITISFoundation:master Oct 9, 2025
58 checks passed
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

🧪 CI Insights

Here's what we observed from your CI run for 8755184.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: front-end continuously call search in the trash view

3 participants