Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 10, 2025

What do these changes do?

In order to detect and avoid issue when configuring the operations, the required initial context keys field has been added to the Operation.

Minor:

  • expose NoDataFoundError via generic_scheduler's interface

Related issue/s

How to test

Dev-ops

@GitHK GitHK added this to the Cheops milestone Oct 10, 2025
@GitHK GitHK self-assigned this Oct 10, 2025
@GitHK GitHK requested a review from Copilot October 10, 2025 07:56
@GitHK GitHK changed the title added initial operation context key requirements 🎨 adds required initial operation context key Oct 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds initial operation context key requirements functionality to the dynamic scheduler. It introduces a mechanism to specify and validate required keys in the initial context when starting operations.

  • Adds initial_context_required_keys parameter to the Operation class
  • Implements validation logic to check for required keys in operation contexts
  • Adds comprehensive test coverage for the new validation functionality

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
_operation.py Adds initial_context_required_keys parameter to Operation constructor
_errors.py Defines new OperationInitialContextKeyNotFoundError exception
_core.py Implements validation logic in start_operation function
_event_after.py Adds validation for operations registered to start after events
test_generic_scheduler.py Comprehensive test coverage for required key validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@GitHK GitHK requested a review from Copilot October 10, 2025 08:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.61%. Comparing base (fd9641d) to head (6262ef5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8495      +/-   ##
==========================================
+ Coverage   87.61%   89.61%   +1.99%     
==========================================
  Files        2001     1576     -425     
  Lines       77905    65033   -12872     
  Branches     1338      496     -842     
==========================================
- Hits        68260    58279    -9981     
+ Misses       9245     6625    -2620     
+ Partials      400      129     -271     
Flag Coverage Δ
integrationtests 64.12% <ø> (-0.03%) ⬇️
unittests 88.06% <100.00%> (+1.75%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.06% <ø> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.89% <ø> (-0.06%) ⬇️
agent 93.10% <ø> (ø)
api_server 91.87% <ø> (ø)
autoscaling 95.72% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 91.81% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (-0.09%) ⬇️
director_v2 91.01% <ø> (+0.06%) ⬆️
dynamic_scheduler 96.82% <100.00%> (+0.01%) ⬆️
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.16% <ø> (+0.05%) ⬆️
storage 86.53% <ø> (-0.05%) ⬇️
webclient ∅ <ø> (∅)
webserver 87.26% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9641d...6262ef5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK marked this pull request as ready for review October 10, 2025 08:07
@GitHK GitHK requested a review from sanderegg as a code owner October 10, 2025 08:07
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

🧪 CI Insights

Here's what we observed from your CI run for 6262ef5.

🟢 All jobs passed!

But CI Insights is watching 👀

@sonarqubecloud
Copy link

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK merged commit aadb582 into ITISFoundation:master Oct 10, 2025
95 checks passed
@GitHK GitHK deleted the pr-osparc-migrate-dy-scheduler-part9 branch October 10, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants