-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 adds required initial operation context key #8495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 adds required initial operation context key #8495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds initial operation context key requirements functionality to the dynamic scheduler. It introduces a mechanism to specify and validate required keys in the initial context when starting operations.
- Adds
initial_context_required_keysparameter to theOperationclass - Implements validation logic to check for required keys in operation contexts
- Adds comprehensive test coverage for the new validation functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
_operation.py |
Adds initial_context_required_keys parameter to Operation constructor |
_errors.py |
Defines new OperationInitialContextKeyNotFoundError exception |
_core.py |
Implements validation logic in start_operation function |
_event_after.py |
Adds validation for operations registered to start after events |
test_generic_scheduler.py |
Comprehensive test coverage for required key validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/dynamic-scheduler/tests/unit/services/generic_scheduler/test_generic_scheduler.py
Outdated
Show resolved
Hide resolved
services/dynamic-scheduler/tests/unit/services/generic_scheduler/test_generic_scheduler.py
Outdated
Show resolved
Hide resolved
services/dynamic-scheduler/tests/unit/services/generic_scheduler/test_generic_scheduler.py
Outdated
Show resolved
Hide resolved
...ynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_errors.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/dynamic-scheduler/tests/unit/services/generic_scheduler/test_generic_scheduler.py
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8495 +/- ##
==========================================
+ Coverage 87.61% 89.61% +1.99%
==========================================
Files 2001 1576 -425
Lines 77905 65033 -12872
Branches 1338 496 -842
==========================================
- Hits 68260 58279 -9981
+ Misses 9245 6625 -2620
+ Partials 400 129 -271
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for 6262ef5. 🟢 All jobs passed!But CI Insights is watching 👀 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍



What do these changes do?
In order to detect and avoid issue when configuring the operations, the required initial context keys field has been added to the
Operation.Minor:
NoDataFoundErrorvia generic_scheduler's interfaceRelated issue/s
How to test
Dev-ops