-
Notifications
You must be signed in to change notification settings - Fork 32
🔨 [Maintenance] Refactor docker-compose.yml to Improve Maintainability via Environment Variable Grouping
#8503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 [Maintenance] Refactor docker-compose.yml to Improve Maintainability via Environment Variable Grouping
#8503
Conversation
…dd common logging settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors docker-compose.yml to improve maintainability by consolidating related environment variables into reusable x-* anchor sections. The refactor replaces duplicated environment variable definitions across services with shared configuration blocks for common services like PostgreSQL, Redis, RabbitMQ, S3, SMTP, and other simcore components.
- Created organized x-* sections grouped by service type (3rd party services vs simcore stack services)
- Replaced individual environment variable declarations with anchor references using
<<:YAML syntax - Added clear section headers to improve readability and organization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8503 +/- ##
==========================================
- Coverage 87.62% 87.60% -0.02%
==========================================
Files 2001 2001
Lines 77920 77933 +13
Branches 1338 1338
==========================================
- Hits 68280 68276 -4
- Misses 9240 9257 +17
Partials 400 400
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
|



What do these changes do?
This refactor improves the maintainability of
docker-compose.ymlby grouping related environment variables into reusablex-*sections with anchors and references/aliases. For instance, settings for common services such as postgres, redis and rabbit and define only once and used aliases to inject them in the service environment section. This approach reduces duplication, simplifies updates, and improves overall readability.Related issue/s
How to test
Compare `.satck-simcore-*.yml produce in master branch
Dev-ops
Please check that this has not side-effects on the compose done on the ops side