Skip to content

Conversation

wvangeit
Copy link
Contributor

@wvangeit wvangeit commented Oct 13, 2025

What do these changes do?

The director-v2 02 tests were taking more than 30 minutes several times in github actions (and timing out). I split the tests in 01 02 03.
@GitHK let me know if this makes sense or not.

Related issue/s

How to test

Run director-v2 03 tests

Dev-ops

@wvangeit wvangeit added this to the Cheops milestone Oct 13, 2025
@wvangeit wvangeit self-assigned this Oct 13, 2025
@wvangeit wvangeit added the a:director-v2 issue related with the director-v2 service label Oct 13, 2025
@wvangeit wvangeit requested a review from Copilot October 13, 2025 08:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR splits the director-v2 integration tests to resolve timeout issues in GitHub Actions. The original 02 test suite was taking over 30 minutes and timing out, so it has been divided into separate test suites 02 and 03.

  • Extracted test utilities and configuration into a new 03 test directory
  • Added a new GitHub Actions workflow for the director-v2 03 integration tests
  • Updated the workflow dependencies to include the new test job

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
services/director-v2/tests/integration/03/utils.py Duplicate of test utilities for the new 03 test suite
services/director-v2/tests/integration/03/conftest.py Duplicate of test configuration fixtures for the new 03 test suite
.github/workflows/ci-testing-deploy.yml Added new workflow job for director-v2 03 tests and updated dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.30%. Comparing base (3ca1fb6) to head (11a6192).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8504      +/-   ##
==========================================
+ Coverage   87.29%   87.30%   +0.01%     
==========================================
  Files        1925     1925              
  Lines       75417    75417              
  Branches     1338     1338              
==========================================
+ Hits        65835    65846      +11     
+ Misses       9182     9171      -11     
  Partials      400      400              
Flag Coverage Δ
integrationtests 64.12% <ø> (+0.03%) ⬆️
unittests 85.96% <ø> (+<0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 84.27% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 93.06% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.95% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.98% <ø> (ø)
pkg_settings_library 90.20% <ø> (ø)
pkg_simcore_sdk 84.89% <ø> (ø)
agent 93.10% <ø> (ø)
api_server 91.86% <ø> (ø)
autoscaling 95.72% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 91.01% <ø> (+0.05%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 90.44% <ø> (-0.03%) ⬇️
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.11% <ø> (-0.11%) ⬇️
storage 86.41% <ø> (+0.20%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.25% <ø> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca1fb6...11a6192. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

mergify bot commented Oct 13, 2025

🧪 CI Insights

Here's what we observed from your CI run for 11a6192.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Healthy 0 View View

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your effort will be wasted here

  • these tests are flaky since forever and they get retried that's why it takes a long time and they timeout
  • These will be replaced in a few sprints once a the new scheduler is in place and working again

I'm not even sure if this will make it worse or better. How was this measured?

@wvangeit wvangeit requested a review from pcrespov October 13, 2025 09:40
Copy link

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitHK @wvangeit

  • if these tests are outdated, @GitHK can you then remove/disable them please? They indeed waste time and resources
  • I would prefer not add yet another job in this case, as this is using additional CI machines
  • can these tests be replaced by system tests in the playwright? or is this already the case? That would be easier, faster..

As reminder:

  • each integration tests needs all the docker images built, downloaded locally and started. If this is for nothing, this takes a lot of minutes for nothing. And that is multiplied by the number of PRs, commits, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants