-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ Split director-v2 02 into 02 and 03 #8504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR splits the director-v2 integration tests to resolve timeout issues in GitHub Actions. The original 02 test suite was taking over 30 minutes and timing out, so it has been divided into separate test suites 02 and 03.
- Extracted test utilities and configuration into a new 03 test directory
- Added a new GitHub Actions workflow for the director-v2 03 integration tests
- Updated the workflow dependencies to include the new test job
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
services/director-v2/tests/integration/03/utils.py | Duplicate of test utilities for the new 03 test suite |
services/director-v2/tests/integration/03/conftest.py | Duplicate of test configuration fixtures for the new 03 test suite |
.github/workflows/ci-testing-deploy.yml | Added new workflow job for director-v2 03 tests and updated dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8504 +/- ##
==========================================
+ Coverage 87.29% 87.30% +0.01%
==========================================
Files 1925 1925
Lines 75417 75417
Branches 1338 1338
==========================================
+ Hits 65835 65846 +11
+ Misses 9182 9171 -11
Partials 400 400
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…e into split-dirv2-tests
🧪 CI InsightsHere's what we observed from your CI run for 11a6192. ❌ Job Failures
✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your effort will be wasted here
- these tests are flaky since forever and they get retried that's why it takes a long time and they timeout
- These will be replaced in a few sprints once a the new scheduler is in place and working again
I'm not even sure if this will make it worse or better. How was this measured?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- if these tests are outdated, @GitHK can you then remove/disable them please? They indeed waste time and resources
- I would prefer not add yet another job in this case, as this is using additional CI machines
- can these tests be replaced by system tests in the playwright? or is this already the case? That would be easier, faster..
As reminder:
- each integration tests needs all the docker images built, downloaded locally and started. If this is for nothing, this takes a lot of minutes for nothing. And that is multiplied by the number of PRs, commits, etc...
What do these changes do?
The director-v2 02 tests were taking more than 30 minutes several times in github actions (and timing out). I split the tests in 01 02 03.
@GitHK let me know if this makes sense or not.
Related issue/s
How to test
Run director-v2 03 tests
Dev-ops