Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 14, 2025

What do these changes do?

The retry_on_errors was not retrying on all the errors as expected, but just on two.
It now retries on any subclass of httpx.TransportError which also avoids errors such as:

""exception_type"": ""<class 'servicelib.fastapi.http_client_thin.ClientHttpError'>"",
  ""exception_string"": ""Received httpx.HTTPError: "",
  ""exception_causes"": ""[ReadTimeout]'' <- [ReadTimeout]''"",
  ""error_code"": ""OEC:31fc80a4c1eb-1760358546868"",

Related issue/s

How to test

Dev-ops

@GitHK GitHK self-assigned this Oct 14, 2025
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Oct 14, 2025
@GitHK GitHK added this to the Imparable milestone Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.39%. Comparing base (7911738) to head (03ddbaa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8513      +/-   ##
==========================================
- Coverage   89.39%   87.39%   -2.01%     
==========================================
  Files        1795     1572     -223     
  Lines       70488    65350    -5138     
  Branches      836      682     -154     
==========================================
- Hits        63014    57112    -5902     
- Misses       7254     7998     +744     
- Partials      220      240      +20     
Flag Coverage Δ
integrationtests 64.02% <ø> (+<0.01%) ⬆️
unittests 85.85% <100.00%> (-2.12%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 70.96% <100.00%> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.95% <ø> (ø)
agent 93.10% <ø> (ø)
api_server 91.86% <ø> (ø)
autoscaling 95.73% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 90.97% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.82% <ø> (ø)
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 91.95% <ø> (-0.27%) ⬇️
storage 86.86% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 87.11% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7911738...03ddbaa. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK marked this pull request as ready for review October 14, 2025 12:06
@GitHK GitHK requested a review from pcrespov as a code owner October 14, 2025 12:06
@GitHK GitHK requested a review from Copilot October 14, 2025 12:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a bug in the retry mechanism for HTTP client requests where only specific error types were being retried instead of all transport-related errors. This was causing failures in director-v2 when monitoring services.

  • Updated retry logic to catch all httpx.TransportError subclasses instead of just ConnectError and PoolTimeout
  • Updated imports to include TransportError and remove the now-unnecessary specific error imports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2025

🧪 CI Insights

Here's what we observed from your CI run for 03ddbaa.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View
unit-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@GitHK GitHK enabled auto-merge (squash) October 14, 2025 13:46
@GitHK GitHK added the t:maintenance Some planned maintenance work label Oct 15, 2025
@sonarqubecloud
Copy link

@GitHK GitHK merged commit 20160d7 into ITISFoundation:master Oct 15, 2025
144 of 148 checks passed
@GitHK GitHK deleted the pr-osparc-try-to-make-better branch October 15, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants