-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fixed failing director-v2 when monitoring services #8513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed failing director-v2 when monitoring services #8513
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8513 +/- ##
==========================================
- Coverage 89.39% 87.39% -2.01%
==========================================
Files 1795 1572 -223
Lines 70488 65350 -5138
Branches 836 682 -154
==========================================
- Hits 63014 57112 -5902
- Misses 7254 7998 +744
- Partials 220 240 +20
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes a bug in the retry mechanism for HTTP client requests where only specific error types were being retried instead of all transport-related errors. This was causing failures in director-v2 when monitoring services.
- Updated retry logic to catch all
httpx.TransportErrorsubclasses instead of justConnectErrorandPoolTimeout - Updated imports to include
TransportErrorand remove the now-unnecessary specific error imports
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🧪 CI InsightsHere's what we observed from your CI run for 03ddbaa. ✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
|



What do these changes do?
The
retry_on_errorswas not retrying on all the errors as expected, but just on two.It now retries on any subclass of
httpx.TransportErrorwhich also avoids errors such as:Related issue/s
How to test
Dev-ops