Skip to content

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Oct 14, 2025

What do these changes do?

Motivated by https://git.speag.com/oSparc/osparc-infra/-/issues/incident/81, this PR batches rpc requests api-server -> wb-api-server to minimize the number of internal requests required to handle the map endpoint in the api-server.

  • With these changes the number of requests api-server->wb-api-server performed when calling the map endpoint does not depend on the number of inputs passed.
  • Previously the map endpoint in the api-server essentially had a loop around the run endpoint which meant that the number of RPC requests api-server->wb-api-server performed when a user called the map endpoint was #inputs*#(requests in run endpoint). With these changes and 🐛 Ensure function execute permission check is performed only once in map endpoint #8499 the number of requests will be #(requests in run endpoint).
image

Related issue/s

How to test

  • This only modifies already existing endpoints in the webserver. Tests have been modified and enhanced accoordingly.

Dev-ops

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.30%. Comparing base (a7cae35) to head (ee7bb37).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8514      +/-   ##
==========================================
- Coverage   87.52%   87.30%   -0.22%     
==========================================
  Files        2009     1615     -394     
  Lines       78515    66250   -12265     
  Branches     1344     1005     -339     
==========================================
- Hits        68721    57842   -10879     
+ Misses       9392     8096    -1296     
+ Partials      402      312      -90     
Flag Coverage Δ
integrationtests 63.91% <18.57%> (-0.05%) ⬇️
unittests 85.78% <85.71%> (-0.46%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.93% <100.00%> (+0.02%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.96% <0.00%> (+0.01%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.95% <ø> (ø)
agent 93.10% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling 95.00% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 90.95% <ø> (+0.05%) ⬆️
dynamic_scheduler 96.82% <0.00%> (ø)
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.11% <ø> (-0.11%) ⬇️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.09% <88.57%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cae35...ee7bb37. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

mergify bot commented Oct 14, 2025

🧪 CI Insights

Here's what we observed from your CI run for ee7bb37.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Broken 0 View View
unit-tests Healthy 0 View View

@odeimaiz odeimaiz added this to the Imparable milestone Oct 15, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.. Following our offline discussion, check the batch operations and see if you can reuse and even extend some of these concepts
tjhx

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants