-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Batch api-server
->wb-api-server
requests in map
endpoint in the api-server
#8514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
🎨 Batch api-server
->wb-api-server
requests in map
endpoint in the api-server
#8514
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8514 +/- ##
==========================================
- Coverage 87.52% 87.30% -0.22%
==========================================
Files 2009 1615 -394
Lines 78515 66250 -12265
Branches 1344 1005 -339
==========================================
- Hits 68721 57842 -10879
+ Misses 9392 8096 -1296
+ Partials 402 312 -90
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx.. Following our offline discussion, check the batch operations and see if you can reuse and even extend some of these concepts
tjhx
...ibrary/src/servicelib/rabbitmq/rpc_interfaces/webserver/functions/functions_rpc_interface.py
Outdated
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/main.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/webserver/v1/functions.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/functions_routes.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rpc.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rpc.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rpc.py
Show resolved
Hide resolved
|
What do these changes do?
Motivated by https://git.speag.com/oSparc/osparc-infra/-/issues/incident/81, this PR batches rpc requests
api-server
->wb-api-server
to minimize the number of internal requests required to handle themap
endpoint in the api-server.api-server
->wb-api-server
performed when calling the map endpoint does not depend on the number of inputs passed.map
endpoint in the api-server essentially had a loop around therun
endpoint which meant that the number of RPC requestsapi-server
->wb-api-server
performed when a user called themap
endpoint was#inputs
*#(requests in run endpoint)
. With these changes and 🐛 Ensure function execute permission check is performed only once in map endpoint #8499 the number of requests will be#(requests in run endpoint)
.Related issue/s
How to test
Dev-ops