- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
✨ Introduce chatbot client (⚠️) #8516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Introduce chatbot client (⚠️) #8516
Conversation
          Codecov Report❌ Patch coverage is  Additional details and impacted files@@            Coverage Diff             @@
##           master    #8516      +/-   ##
==========================================
+ Coverage   85.67%   87.57%   +1.89%     
==========================================
  Files        2003     2007       +4     
  Lines       78196    78294      +98     
  Branches     1343     1343              
==========================================
+ Hits        66994    68563    +1569     
+ Misses      10800     9329    -1471     
  Partials      402      402              
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
          
🧪 CI InsightsHere's what we observed from your CI run for 6a2dd0a. ✅ Passed Jobs With Interesting Signals
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
        
          
                services/web/server/src/simcore_service_webserver/chatbot/_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. left some comments
        
          
                services/web/server/src/simcore_service_webserver/chatbot/_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/chatbot/_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/chatbot/_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new chatbot client that enables the webserver to communicate with a chatbot service. The implementation includes proper settings management, REST client functionality with retry logic, and integration into the conversations module.
Key changes:
- Adds chatbot REST client with async context manager support and retry mechanisms
 - Integrates chatbot setup into the conversations plugin
 - Removes duplicate fogbugz setup from main application in favor of conversations-managed setup
 
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description | 
|---|---|
| services/web/server/tests/unit/with_dbs/04/test_chatbot_client.py | Unit tests for chatbot client functionality | 
| services/web/server/src/simcore_service_webserver/conversations/plugin.py | Integrates chatbot setup into conversations module | 
| services/web/server/src/simcore_service_webserver/chatbot/settings.py | Configuration settings for chatbot service connection | 
| services/web/server/src/simcore_service_webserver/chatbot/plugin.py | Plugin setup and initialization for chatbot module | 
| services/web/server/src/simcore_service_webserver/chatbot/_client.py | REST client implementation with retry logic and async support | 
| services/web/server/src/simcore_service_webserver/chatbot/init.py | Module exports for chatbot functionality | 
| services/web/server/src/simcore_service_webserver/application_settings.py | Adds chatbot settings to application configuration | 
| services/web/server/src/simcore_service_webserver/application.py | Removes redundant fogbugz setup | 
| services/docker-compose.yml | Environment variable configuration for chatbot service | 
| .env-devel | Development environment configuration | 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
        
          
                services/web/server/src/simcore_service_webserver/chatbot/_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/chatbot/plugin.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
        
          
                services/web/server/src/simcore_service_webserver/chatbot/_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/chatbot/_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/chatbot/_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/tests/unit/with_dbs/04/test_chatbot_client.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
          
 | 
    
6213a3d
      into
      
  
    ITISFoundation:master
  
    


What do these changes do?
Related issue/s
How to test
services/web/server/tests/unit/with_dbs/04/test_chatbot_client.pyDev-ops
WEBSERVER_CHATBOThttps://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1634