Skip to content

✨ Introduce chatbot client (⚠️) #8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 15, 2025
Merged

✨ Introduce chatbot client (⚠️) #8516

merged 17 commits into from
Oct 15, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Oct 14, 2025 •
edited
Loading

What do these changes do?

  • ✨ Introduce chatbot client

Related issue/s

How to test

services/web/server/tests/unit/with_dbs/04/test_chatbot_client.py

Dev-ops

⚠️ New env var WEBSERVER_CHATBOT
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1634

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 14, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Oct 14, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Imparable milestone Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.57%. Comparing base (20160d7) to head (6a2dd0a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8516      +/-   ##
==========================================
+ Coverage   85.67%   87.57%   +1.89%     
==========================================
  Files        2003     2007       +4     
  Lines       78196    78294      +98     
  Branches     1343     1343              
==========================================
+ Hits        66994    68563    +1569     
+ Misses      10800     9329    -1471     
  Partials      402      402
Flag Coverage Δ
integrationtests 63.97% <50.00%> (+3.49%) ⬆️
unittests 86.28% <82.00%> (+1.40%) ⬆️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 85.83% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 92.90% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.95% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.96% <ø> (ø)
pkg_settings_library 90.20% <ø> (ø)
pkg_simcore_sdk 84.89% <ø> (ø)
agent 93.10% <ø> (ø)
api_server 91.86% <ø> (ø)
autoscaling 95.73% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (+0.55%) ⬆️
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 91.01% <ø> (+5.69%) ⬆️
dynamic_scheduler 96.82% <ø> (ø)
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.27% <ø> (ø)
storage 86.50% <ø> (-0.09%) ⬇️
webclient ∅ <ø> (∅)
webserver 87.09% <82.00%> (+4.62%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20160d7...6a2dd0a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 6a2dd0a.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 15, 2025 07:20
giancarloromeo
giancarloromeo approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@matusdrobuliak66 matusdrobuliak66 changed the title ✨ Introduce chatbot client ✨ Introduce chatbot client (⚠️) Oct 15, 2025
GitHK
GitHK approved these changes Oct 15, 2025
View reviewed changes
pcrespov
pcrespov reviewed Oct 15, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. left some comments

pcrespov
pcrespov reviewed Oct 15, 2025
View reviewed changes
@pcrespov pcrespov requested a review from Copilot October 15, 2025 07:46
Copilot AI reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new chatbot client that enables the webserver to communicate with a chatbot service. The implementation includes proper settings management, REST client functionality with retry logic, and integration into the conversations module.

Key changes:

  • Adds chatbot REST client with async context manager support and retry mechanisms
  • Integrates chatbot setup into the conversations plugin
  • Removes duplicate fogbugz setup from main application in favor of conversations-managed setup

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
services/web/server/tests/unit/with_dbs/04/test_chatbot_client.py Unit tests for chatbot client functionality
services/web/server/src/simcore_service_webserver/conversations/plugin.py Integrates chatbot setup into conversations module
services/web/server/src/simcore_service_webserver/chatbot/settings.py Configuration settings for chatbot service connection
services/web/server/src/simcore_service_webserver/chatbot/plugin.py Plugin setup and initialization for chatbot module
services/web/server/src/simcore_service_webserver/chatbot/_client.py REST client implementation with retry logic and async support
services/web/server/src/simcore_service_webserver/chatbot/init.py Module exports for chatbot functionality
services/web/server/src/simcore_service_webserver/application_settings.py Adds chatbot settings to application configuration
services/web/server/src/simcore_service_webserver/application.py Removes redundant fogbugz setup
services/docker-compose.yml Environment variable configuration for chatbot service
.env-devel Development environment configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

mrnicegyu11
mrnicegyu11 approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

bisgaard-itis
bisgaard-itis approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks

pcrespov
pcrespov approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

pcrespov
pcrespov reviewed Oct 15, 2025
View reviewed changes
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 15, 2025 12:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit 6213a3d into ITISFoundation:master Oct 15, 2025
145 of 148 checks passed
bisgaard-itis pushed a commit to bisgaard-itis/osparc-simcore that referenced this pull request Oct 15, 2025
@matusdrobuliak66 @bisgaard-itis
✨ Introduce chatbot client (⚠️) (ITISFoundation#8516)
43b9082
This was referenced Oct 28, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

Copilot code review Copilot Copilot left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Imparable

Development

Successfully merging this pull request may close these issues.

7 participants

@matusdrobuliak66 @giancarloromeo @GitHK @mrnicegyu11 @pcrespov @YuryHrytsuk @bisgaard-itis