🎨 Allow case-insensitive filename matching #8522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8522 +/- ##
==========================================
+ Coverage 87.55% 89.52% +1.97%
==========================================
Files 2007 1582 -425
Lines 78401 65462 -12939
Branches 1343 499 -844
==========================================
- Hits 68644 58608 -10036
+ Misses 9355 6724 -2631
+ Partials 402 130 -272
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
giancarloromeo
commented
Oct 15, 2025
packages/models-library/src/models_library/api_schemas_storage/search_async_jobs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the file search functionality to support case-insensitive filename matching using wildcards. The main implementation changes the filename pattern matching logic to compare both the filename and pattern in lowercase, enabling users to search for files regardless of case variations.
- Modified the
fnmatchcomparison in the search logic to perform case-insensitive matching - Added comprehensive test coverage for various case-insensitive pattern matching scenarios
- Renamed the search task constant for improved clarity
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/storage/src/simcore_service_storage/simcore_s3_dsm.py | Updated filename matching logic to convert both filename and pattern to lowercase for case-insensitive comparison |
| services/storage/tests/unit/test_simcore_s3_dsm.py | Added comprehensive test cases covering case-insensitive matching for extensions, prefixes, and mixed-case patterns |
| packages/models-library/src/models_library/api_schemas_storage/search_async_jobs.py | Changed task name from "files.search" to "files_search" (dot to underscore) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/models-library/src/models_library/api_schemas_storage/search_async_jobs.py
Show resolved
Hide resolved
giancarloromeo
requested review from
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
🧪 CI InsightsHere's what we observed from your CI run for 32855b4. 🟢 All jobs passed!But CI Insights is watching 👀 |
|
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR enhances the file search functionality to support case-insensitive filename matching using wildcards. The main implementation changes the filename pattern matching logic to compare both the filename and pattern in lowercase, enabling users to search for files regardless of case variations.
fnmatchcomparison in the search logic to perform case-insensitive matchingRelated issue/s
How to test
Dev-ops