- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
♻️E2E: Fix DEBUG logging not outputing to the logs #8523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️E2E: Fix DEBUG logging not outputing to the logs #8523
Conversation
f033bf2    to
    d59d96f      
    Compare
  
    
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##           master    #8523      +/-   ##
==========================================
+ Coverage   87.01%   87.55%   +0.53%     
==========================================
  Files        2007     2007              
  Lines       78402    78402              
  Branches     1343     1343              
==========================================
+ Hits        68222    68641     +419     
+ Misses       9778     9359     -419     
  Partials      402      402              
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
          
🧪 CI InsightsHere's what we observed from your CI run for ee086aa. 🟢 All jobs passed!But CI Insights is watching 👀  | 
    
d59d96f    to
    ee086aa      
    Compare
  
    | 
           @mergify queue  | 
    
          
 🟠 Waiting for conditions to match
  | 
    
          
 | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍



What do these changes do?
With the goal of fixing the "videostreaming does not work" assumption, this PR fixes the logging level being hard-coded to INFO.
The idea here is to permit DEBUG logging to see what are the messages coming into the websocket when running on CI machines. Locally I was unable to reproduce that problem out of >20 times.
This will be very verbose, but that might at least give a hint

Related issue/s
How to test
Dev-ops