🐛 Fix: initialize 3rd party libs #8527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR fixes initialization issues with JavaScript wrapper libraries by converting their init() methods to return Promises and ensuring proper async/await handling. The changes move library initialization from synchronous calls in the Dashboard to properly awaited calls in the Application startup flow.
- Convert
IntlTelInputandDOMPurifywrapper initialization methods to return Promises - Move library initialization from Dashboard to Application with proper async/await pattern
- Ensure libraries are fully loaded before application continues startup
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| osparc/wrapper/IntlTelInput.js | Wraps init method in Promise to handle async library loading |
| osparc/wrapper/DOMPurify.js | Wraps init method in Promise to handle async library loading |
| osparc/dashboard/Dashboard.js | Removes synchronous DOMPurify initialization call |
| osparc/Application.js | Adds proper async/await initialization for both wrapper libraries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/static-webserver/client/source/class/osparc/Application.js
Outdated
Show resolved
Hide resolved
…on.js Co-authored-by: Copilot <[email protected]>
…ore into fix/init-dom-purify
|
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
pcrespov and
sanderegg
pcrespov
approved these changes
Oct 17, 2025
GitHK
approved these changes
Oct 17, 2025
🧪 CI InsightsHere's what we observed from your CI run for 30faf37. ✅ Passed Jobs With Interesting Signals
|
matusdrobuliak66
approved these changes
Oct 17, 2025
sanderegg
approved these changes
Oct 17, 2025
matusdrobuliak66
pushed a commit
that referenced
this pull request
Oct 17, 2025
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes initialization of some 3rd party libraries by converting their init() methods to return Promises and ensuring proper async/await handling.
reported by @matusdrobuliak66
Related issue/s
How to test
Dev-ops