Skip to content

Conversation

pcrespov
Copy link
Member

What do these changes do?

A new push to error handling mechanisms for the web-api

  • review strategy
  • ✨ NEW: adds SupportID to unusual 4XX i.e. which implies it produces a log on the server-side
  • ✨ All message in ErrorGet model (both main and details) MUST be user-friendly (agreed with front-end)
  • ♻️ Common sentences move to common_library.error_messages to keep consistency

Related issue/s

How to test

Dev-ops

@pcrespov pcrespov self-assigned this Oct 17, 2025
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:services-library issues on packages/service-libs a:api framework api, data schemas, t:maintenance Some planned maintenance work labels Oct 17, 2025
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.04%. Comparing base (1856258) to head (97e8aa9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8528      +/-   ##
==========================================
- Coverage   87.44%   87.04%   -0.40%     
==========================================
  Files        1959     1392     -567     
  Lines       76525    58441   -18084     
  Branches     1343      236    -1107     
==========================================
- Hits        66916    50872   -16044     
+ Misses       9207     7495    -1712     
+ Partials      402       74     -328     
Flag Coverage Δ
integrationtests 63.99% <100.00%> (-0.03%) ⬇️
unittests 85.31% <70.00%> (-0.82%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.95% <ø> (-0.06%) ⬇️
agent 93.10% <ø> (ø)
api_server 91.62% <ø> (-0.14%) ⬇️
autoscaling 95.00% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 90.95% <ø> (-0.03%) ⬇️
dynamic_scheduler 96.82% <ø> (ø)
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.06% <ø> (∅)
storage 86.61% <ø> (+0.02%) ⬆️
webclient ∅ <ø> (∅)
webserver 81.10% <100.00%> (-6.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1856258...97e8aa9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Contributor

mergify bot commented Oct 17, 2025

🧪 CI Insights

Here's what we observed from your CI run for 97e8aa9.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Broken 0 View View
unit-tests Healthy 0 View View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:api framework api, data schemas, a:services-library issues on packages/service-libs a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant