Skip to content

Conversation

matusdrobuliak66
Copy link
Collaborator

What do these changes do?

  • 🐛 [user request] Creating a template without data shouldn't complain about study size

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 20, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Imparable milestone Oct 20, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 20, 2025 14:54
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.19%. Comparing base (a7cae35) to head (e1ae653).

❗ There is a different number of reports uploaded between BASE (a7cae35) and HEAD (e1ae653). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (a7cae35) HEAD (e1ae653)
unittests 32 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8533      +/-   ##
==========================================
- Coverage   87.52%   81.19%   -6.33%     
==========================================
  Files        2009      784    -1225     
  Lines       78515    35650   -42865     
  Branches     1344      175    -1169     
==========================================
- Hits        68721    28947   -39774     
+ Misses       9392     6646    -2746     
+ Partials      402       57     -345     
Flag Coverage Δ
integrationtests 63.90% <0.00%> (-0.06%) ⬇️
unittests 81.60% <0.00%> (-4.64%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.81% <ø> (-8.15%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.03% <ø> (-12.88%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.89% <ø> (-8.55%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 82.41% <0.00%> (-4.67%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cae35...e1ae653. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 20, 2025 15:09
Copy link
Contributor

mergify bot commented Oct 20, 2025

🧪 CI Insights

Here's what we observed from your CI run for e1ae653.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Broken 0 View View
unit-tests Healthy 0 View View

Copy link

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matusdrobuliak66 thx. It would be nice that we spot user-requests and highlight them in the release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a template without data shouldn't complain about study size

5 participants