Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 21, 2025

What do these changes do?

  • Enhanced search results display with a structured grid layout instead of raw JSON
  • Fixed sorting of pending users by properly extracting dates from different request statuses
  • Added introductory text and improved layout for the Review Users section /#/review-users
  • Implemented anchor routing (/#/review-users) to directly access the Review Users page

Bonus:

POCenter

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Oct 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

🧪 CI Insights

Here's what we observed from your CI run for ef514a5.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
system-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@odeimaiz odeimaiz added this to the Imparable milestone Oct 21, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 21, 2025
@odeimaiz odeimaiz marked this pull request as ready for review October 21, 2025 15:09
@odeimaiz odeimaiz requested a review from Copilot October 21, 2025 15:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements several improvements to the PO (Product Owner) Center frontend, focusing on user review functionality and UI enhancements.

Key Changes:

  • Fixed sorting of pending users by properly extracting dates from different request statuses
  • Added introductory text and improved layout for the Review Users section
  • Implemented anchor routing (/#/review-users) to directly access the Review Users page
  • Enhanced search results display with a structured grid layout instead of raw JSON

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
osparc/support/Conversation.js Added chatbot check to conditionally display follow-up messages
osparc/store/Groups.js Added chatbot property to store chatbot group information
osparc/po/UsersPending.js Refactored date extraction logic, added header layout with intro text, improved UI structure
osparc/po/Users.js Replaced JSON output with structured grid layout for search results, added Enter key command for search
osparc/po/POCenterWindow.js Added openPage parameter to support direct navigation to specific tabs
osparc/po/POCenter.js Implemented page ID system and navigation logic for anchor routing
osparc/data/model/ConversationSupport.js Added markAsUnread parameter to control conversation read status
osparc/data/model/Conversation.js Updated message loading to not mark as unread during initial fetch
osparc/Application.js Implemented review-users route handling and refactored loadAfterLogin structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Oct 21, 2025
@odeimaiz
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Oct 21, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I also added - PO center: https://{{host}}#/review-users to my #8545

@sonarqubecloud
Copy link

@odeimaiz odeimaiz enabled auto-merge (squash) October 22, 2025 06:48
@odeimaiz odeimaiz merged commit ab03ba7 into ITISFoundation:master Oct 22, 2025
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants