Skip to content

🎨E2E: improve logging of websocket messages #8550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

🎨E2E: improve logging of websocket messages #8550

merged 1 commit into from
Oct 23, 2025

Conversation

@sanderegg
Copy link
Member

What do these changes do?

  • ensures websocket messages can be clearly identified in the gitlab CI later on by adding a prefix whether they are osparc or s4l websocket messages

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Imparable milestone Oct 23, 2025
@sanderegg sanderegg self-assigned this Oct 23, 2025
@sanderegg sanderegg added t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing labels Oct 23, 2025
GitHK
GitHK approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for c74f061.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests You had a 41% chance of failing… lucky you! 🎲 Flaky Configure an automatic retry View View

@sanderegg sanderegg merged commit d6b73db into ITISFoundation:master Oct 23, 2025
3 of 4 checks passed
@sanderegg sanderegg deleted the e2e/fix-logging branch October 23, 2025 16:04
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 28, 2025
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

@pcrespov pcrespov Awaiting requested review from pcrespov

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@sanderegg sanderegg

Labels

e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Imparable

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @giancarloromeo @GitHK @odeimaiz