🐛 [Frontend] Fix: no-read default accessRights for the chatbot user #8551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the handling of default access rights for groups by moving the default access rights logic from the caller to the Group model constructor. The change simplifies group initialization and makes the code more maintainable by centralizing the default access rights logic.
Key changes:
- Default access rights are now set in the Group model constructor when accessRights are not provided
- Chatbot group handling is unified to use the same
__addToGroupsCachemethod as other groups - Added "chatbot" as a valid groupType in the Group model
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/store/Groups.js | Removed manual setting of default accessRights for support group; unified chatbot group initialization to use __addToGroupsCache |
| services/static-webserver/client/source/class/osparc/data/model/Group.js | Added default accessRights in constructor and "chatbot" to valid groupType values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
odeimaiz
changed the title
odeimaiz
changed the title
|
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
giancarloromeo
approved these changes
Oct 23, 2025
GitHK
approved these changes
Oct 23, 2025
🧪 CI InsightsHere's what we observed from your CI run for c44342b. ✅ Passed Jobs With Interesting Signals
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes the initialization of the
chatbot"group" by defaulting its accessRights to no-readRelated issue/s
How to test
Dev-ops