Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 24, 2025

What do these changes do?

This PR addresses error handling for the /group/{gid}/users API endpoint by adding proper error catching. This prevents the frontend from being stuck during the start up process.

ShowError

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz requested a review from Copilot October 24, 2025 07:42
@odeimaiz odeimaiz enabled auto-merge (squash) October 24, 2025 07:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses error handling for the /group/{gid}/users API endpoint by adding proper error catching and improving variable naming for clarity.

  • Added error handler to catch and log errors when fetching group members
  • Renamed groupId parameter to userGroupId in user fetching methods for clarity

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
services/static-webserver/client/source/class/osparc/store/Users.js Renamed groupId parameter to userGroupId throughout user fetching methods
services/static-webserver/client/source/class/osparc/store/Groups.js Added error catch handler to log errors when fetching group members

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@odeimaiz odeimaiz self-assigned this Oct 24, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 24, 2025
@odeimaiz odeimaiz added this to the Imparable milestone Oct 24, 2025
@sonarqubecloud
Copy link

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

🧪 CI Insights

Here's what we observed from your CI run for 8fa983d.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests You had a 24% chance of failing… lucky you! 🎲 Flaky Configure an automatic retry View View

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx
what error was raised in /group/{gid}/users ? You mentioned in the chat a 504 Gateway Timeout but do you have the response? I wonder whether it was the webserver or some of the reverse proxies in front.

@odeimaiz odeimaiz merged commit 1c61999 into ITISFoundation:master Oct 24, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants