-
Couldn't load subscription status.
- Fork 32
🐛 [Frontend] Fix: catch error /group/{gid}/users
#8552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses error handling for the /group/{gid}/users API endpoint by adding proper error catching and improving variable naming for clarity.
- Added error handler to catch and log errors when fetching group members
- Renamed
groupIdparameter touserGroupIdin user fetching methods for clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/store/Users.js | Renamed groupId parameter to userGroupId throughout user fetching methods |
| services/static-webserver/client/source/class/osparc/store/Groups.js | Added error catch handler to log errors when fetching group members |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🧪 CI InsightsHere's what we observed from your CI run for 8fa983d. ✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
what error was raised in /group/{gid}/users ? You mentioned in the chat a 504 Gateway Timeout but do you have the response? I wonder whether it was the webserver or some of the reverse proxies in front.



What do these changes do?
This PR addresses error handling for the /group/{gid}/users API endpoint by adding proper error catching. This prevents the frontend from being stuck during the start up process.
Related issue/s
How to test
Dev-ops