🐛Autoscaling: fixes unknown passing type to dask-scheduler #8556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
t:maintenance
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where an incorrect type (_DaskClusterTasks TypedDict) was being passed to the dask-scheduler, causing type-related issues. The fix changes the return type from the custom _DaskClusterTasks TypedDict to a plain dict[str, Any] and removes the type-ignore comments that were masking the underlying issue.
Key Changes:
- Modified the return type of the inner
_list_on_schedulerfunction from_DaskClusterTaskstodict[str, Any] - Replaced TypedDict instantiation with a plain dictionary literal
- Removed type-ignore comments that were previously suppressing the type errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
sanderegg
added a commit
to sanderegg/osparc-simcore
that referenced
this pull request
Oct 24, 2025
…TISFoundation#8556)" This reverts commit 4d1cccd.
sanderegg
added a commit
to sanderegg/osparc-simcore
that referenced
this pull request
Oct 24, 2025
sanderegg
added a commit
that referenced
this pull request
Oct 24, 2025
sanderegg
added a commit
to sanderegg/osparc-simcore
that referenced
this pull request
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
#8423 brought some refactoring and one of them passes a type defined in
autoscalingservice to the dask-scheduler. This is not allowed and fails. This PR fixes this.Related issue/s
How to test
Dev-ops