✨♻️Autoscaling/dask nthreads2 🚨 🚨 🚨 #8558
Open
+1,103
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker is computed for autoscaling 🚨🚨🚨 (ITISFoundation#8423) Co-authored-by: Copilot <[email protected]>
sanderegg
force-pushed
the
autoscaling/dask-nthreads2
branch
from
4c40854 to
e3d2a06
Compare
This reverts commit e3d2a06.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8558 +/- ##
==========================================
- Coverage 87.52% 87.44% -0.08%
==========================================
Files 2011 1608 -403
Lines 78612 66977 -11635
Branches 1351 764 -587
==========================================
- Hits 68802 58566 -10236
+ Misses 9406 8158 -1248
+ Partials 404 253 -151
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
requested review from
GitHK,
matusdrobuliak66 and
pcrespov
as code owners
|
pcrespov
approved these changes
Oct 25, 2025
| def as_flat_dict(self) -> dict[str, int | float | str]: | ||
| """Like model_dump, but flattens generic_resources to top level keys""" | ||
| base = self.model_dump() | ||
| base.update(base.pop("generic_resources")) |
There was a problem hiding this comment.
MIONR: just as a precaution in case one day you add another object-like field , here i would do it in a more general fashion. I know right now is perhaps an overkill, but it might be handy to add some helpers like this in common_library.dict_tools so that afterwards we could do something like
common_library.dict_tools.flatten(self.model_dump(mode='json'))A draft courtesy of chatty (double check first!)
def _flatten(obj, prefix=""):
items = {}
if isinstance(obj, dict):
for k, v in obj.items():
items.update(_flatten(v, f"{prefix}{k}." if prefix else k))
elif isinstance(obj, list):
for i, v in enumerate(obj):
items.update(_flatten(v, f"{prefix}{i}." if prefix else f"{i}"))
else:
items[prefix] = obj
return items
def as_flat_dict(self) -> dict[str, int | float | str]:
"""Recursively flattens all nested dicts/lists into a single-level dict."""
return _flatten(self.model_dump(mode='json'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Second trial at refactoring autoscaling like in #8423
Re-revert #8557
The problem was due to an infortunate refactoring in
services/autoscaling/src/simcore_service_autoscaling/models.py/.Added a note and an issue for refactoring that problem:
#8559
Related issue/s
How to test
Dev-ops