Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 6, 2026

What do these changes do?

#8692 has set the wrong type for DIRECTOR_OSPARC_CUSTOM_DOCKER_PLACEMENT_CONSTRAINTS and DIRECTOR_V2_DYNAMIC_SIDECAR_OSPARC_CUSTOM_DOCKER_PLACEMENT_CONSTRAINTS, this fixes it.

Related issue/s

How to test

Dev-ops

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.68%. Comparing base (27f491d) to head (1dc5439).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (27f491d) and HEAD (1dc5439). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (27f491d) HEAD (1dc5439)
unittests 32 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8719       +/-   ##
===========================================
- Coverage   87.47%   68.68%   -18.80%     
===========================================
  Files        2018      796     -1222     
  Lines       79384    36596    -42788     
  Branches     1389      154     -1235     
===========================================
- Hits        69445    25135    -44310     
- Misses       9543    11412     +1869     
+ Partials      396       49      -347     
Flag Coverage Δ
integrationtests 63.91% <ø> (+0.04%) ⬆️
unittests 83.29% <ø> (-3.02%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 75.36% <ø> (-9.10%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director 75.45% <ø> (ø)
director_v2 91.19% <ø> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.94% <ø> (-8.82%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.77% <ø> (-27.83%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f491d...1dc5439. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg self-assigned this Jan 6, 2026
@sanderegg sanderegg added a:director issue related with the director service a:director-v2 issue related with the director-v2 service 🤖-automerge marks PR as ready to be merged for Mergify labels Jan 6, 2026
@sanderegg sanderegg added this to the Delirium Noel milestone Jan 6, 2026
@sanderegg sanderegg force-pushed the bugfix/wrong-pydantic-types branch from b13d928 to 1dc5439 Compare January 6, 2026 08:06
@sanderegg sanderegg marked this pull request as ready for review January 6, 2026 08:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

@sanderegg
Copy link
Member Author

@mergify queue

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a better PR title, thanks

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2026

queue

🛑 Configuration not compatible with a branch protection setting

Details

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2026

Merge Queue Status

🛑 Queue command has been cancelled

@sanderegg sanderegg changed the title fix 🐛Fix custom constraint key type Jan 6, 2026
@sanderegg sanderegg changed the title 🐛Fix custom constraint key type 🐛Fix docker service custom constraints key type Jan 6, 2026
@sanderegg
Copy link
Member Author

Please use a better PR title, thanks

??? I guess you were slightly too fast, or me slightly too slow to change it... anyway... let me know if it is unclear.

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice typing!

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2026

🧪 CI Insights

Here's what we observed from your CI run for 1dc5439.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests You had a 50% chance of failing… lucky you! 🎲 Flaky Configure an automatic retry View View

@sanderegg sanderegg merged commit 5aaa8f6 into ITISFoundation:master Jan 6, 2026
91 of 94 checks passed
@sanderegg sanderegg deleted the bugfix/wrong-pydantic-types branch January 6, 2026 08:29
@sanderegg sanderegg changed the title 🐛Fix docker service custom constraints key type 🐛Fix docker service custom constraints key type (⚠️ devops) Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:director issue related with the director service a:director-v2 issue related with the director-v2 service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add autoscaling service per product to prevent mixing billable and not billable services to run on same machines

3 participants