-
Notifications
You must be signed in to change notification settings - Fork 31
🐛Fix docker service custom constraints key type (⚠️ devops) #8719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fix docker service custom constraints key type (⚠️ devops) #8719
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #8719 +/- ##
===========================================
- Coverage 87.47% 68.68% -18.80%
===========================================
Files 2018 796 -1222
Lines 79384 36596 -42788
Branches 1389 154 -1235
===========================================
- Hits 69445 25135 -44310
- Misses 9543 11412 +1869
+ Partials 396 49 -347
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
b13d928 to
1dc5439
Compare
|
|
@mergify queue |
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a better PR title, thanks
🛑 Configuration not compatible with a branch protection settingDetailsThe branch protection setting |
Merge Queue Status🛑 Queue command has been cancelled |
??? I guess you were slightly too fast, or me slightly too slow to change it... anyway... let me know if it is unclear. |
YuryHrytsuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice typing!
🧪 CI InsightsHere's what we observed from your CI run for 1dc5439. ✅ Passed Jobs With Interesting Signals
|



What do these changes do?
#8692 has set the wrong type for
DIRECTOR_OSPARC_CUSTOM_DOCKER_PLACEMENT_CONSTRAINTSandDIRECTOR_V2_DYNAMIC_SIDECAR_OSPARC_CUSTOM_DOCKER_PLACEMENT_CONSTRAINTS, this fixes it.Related issue/s
How to test
Dev-ops