Skip to content

🐛 Ephemeral group tasks are not removed#8967

Open
giancarloromeo wants to merge 30 commits intoITISFoundation:masterfrom
giancarloromeo:fix/remove-ephemeral-group-tasks-on-complete
Open

🐛 Ephemeral group tasks are not removed#8967
giancarloromeo wants to merge 30 commits intoITISFoundation:masterfrom
giancarloromeo:fix/remove-ephemeral-group-tasks-on-complete

Conversation

@giancarloromeo
Copy link
Copy Markdown
Contributor

@giancarloromeo giancarloromeo commented Mar 26, 2026

What do these changes do?

This pull request enhances the Celery task management system by unifying and improving how results and statuses are retrieved for both individual tasks and task groups. It introduces a new generic get_result method, improves error handling, and ensures proper cleanup for ephemeral groups.

Related issue/s

How to test

cd packages/celery-library
make install-dev
pytest -vv --pdb tests/unit/test_task_manager.py

Dev-ops

  • No changes.

@giancarloromeo giancarloromeo added this to the Cassata milestone Mar 26, 2026
@giancarloromeo giancarloromeo self-assigned this Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 76.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.73%. Comparing base (9913368) to head (42cc90f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8967      +/-   ##
==========================================
- Coverage   87.49%   86.73%   -0.76%     
==========================================
  Files        2068     2068              
  Lines       81586    81604      +18     
  Branches     1434     1438       +4     
==========================================
- Hits        71380    70782     -598     
- Misses       9801    10412     +611     
- Partials      405      410       +5     
Flag Coverage Δ
integrationtests 64.07% <0.00%> (-0.01%) ⬇️
unittests 86.27% <76.00%> (-0.11%) ⬇️
Components Coverage Δ
pkg_aws_library 95.29% <ø> (ø)
pkg_celery_library 77.71% <76.25%> (+0.47%) ⬆️
pkg_dask_task_models_library 79.37% <ø> (ø)
pkg_models_library 92.55% <ø> (ø)
pkg_notifications_library 84.48% <ø> (ø)
pkg_postgres_database 89.24% <ø> (ø)
pkg_service_integration 72.81% <ø> (ø)
pkg_service_library 70.31% <ø> (ø)
pkg_settings_library 90.48% <ø> (ø)
pkg_simcore_sdk 85.73% <ø> (ø)
agent 92.85% <ø> (ø)
api_server 91.38% <100.00%> (+<0.01%) ⬆️
autoscaling 95.54% <ø> (ø)
catalog 92.10% <ø> (ø)
clusters_keeper 98.70% <ø> (ø)
dask_sidecar 91.54% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.45% <ø> (ø)
director_v2 91.67% <ø> (-0.06%) ⬇️
dynamic_scheduler 96.02% <ø> (ø)
dynamic_sidecar 74.48% <ø> (-13.81%) ⬇️
efs_guardian 89.85% <ø> (ø)
invitations 90.93% <ø> (ø)
payments 92.86% <ø> (ø)
resource_usage_tracker 91.43% <ø> (-0.48%) ⬇️
storage 86.65% <100.00%> (-0.05%) ⬇️
webclient ∅ <ø> (∅)
webserver 86.86% <0.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9913368...42cc90f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo marked this pull request as ready for review March 26, 2026 20:49

This comment was marked as resolved.

….com:giancarloromeo/osparc-simcore into fix/remove-ephemeral-group-tasks-on-complete
Copy link
Copy Markdown
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

Copy link
Copy Markdown
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having 2 methods that overlap in functionality is wrong. Can you please address this?

Copy link
Copy Markdown
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@giancarloromeo giancarloromeo added the bug buggy, it does not work as expected label Mar 27, 2026
Copy link
Copy Markdown
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@giancarloromeo giancarloromeo enabled auto-merge (squash) March 27, 2026 13:01
@sonarqubecloud
Copy link
Copy Markdown

@giancarloromeo
Copy link
Copy Markdown
Contributor Author

@mergify queue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 27, 2026

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Required conditions to enter a queue
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • label=🤖-automerge
      • any of [🛡 GitHub branch protection]:
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of [🛡 GitHub branch protection]:
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of [🛡 GitHub branch protection]:
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of [🛡 GitHub branch protection]:
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of [🛡 GitHub branch protection]:
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of [🛡 GitHub branch protection]:
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of [🛡 GitHub branch protection]:
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:celery-library bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants