Skip to content

Begin implementation of null #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Begin implementation of null #128

merged 2 commits into from
May 30, 2025

Conversation

mtfishman
Copy link
Member

This gets some of the interface infrastructure in place for left_null/right_null, including throwing errors instead of silently giving strange results.

My plan is to merge this and work on the actual implementation in a future PR. Both QR and SVD backends will be a little subtle to implement.

Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 74.15%. Comparing base (2578245) to head (013e0c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/factorizations/orthnull.jl 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   74.94%   74.15%   -0.80%     
==========================================
  Files          34       34              
  Lines        1688     1706      +18     
==========================================
  Hits         1265     1265              
- Misses        423      441      +18     
Flag Coverage Δ
docs 6.68% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman merged commit 6bee699 into main May 30, 2025
17 of 19 checks passed
@mtfishman mtfishman deleted the mf/null_init branch May 30, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant