Skip to content

Block sparse eig #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2025
Merged

Block sparse eig #129

merged 9 commits into from
Jun 5, 2025

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented May 30, 2025

Also simplifies and generalizes the default_f_algorithm logic across factorizations. Depends on QuantumKitHub/MatrixAlgebraKit.jl#32.

To do:

  • Add tests.
  • Check the inputs are block diagonal and square.
  • eig[h]_trunc.
  • eig[h]_vals.
  • Make the type of the block diagonal matrix storing the eigenvalues more specific. In particular, right now the blocks are dense, while they should be Diagonal. To implement that, I plan to add support for similar(A, BlockType(...)) as discussed elsewhere.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.84%. Comparing base (ea250bb) to head (4df87f4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/factorizations/eig.jl 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   74.26%   74.84%   +0.57%     
==========================================
  Files          34       35       +1     
  Lines        1702     1749      +47     
==========================================
+ Hits         1264     1309      +45     
- Misses        438      440       +2     
Flag Coverage Δ
docs 6.52% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman changed the title [WIP] Block sparse eig Block sparse eig Jun 5, 2025
@mtfishman mtfishman marked this pull request as ready for review June 5, 2025 14:58
@mtfishman mtfishman merged commit 78188cc into main Jun 5, 2025
19 checks passed
@mtfishman mtfishman deleted the mf/eig branch June 5, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant