Skip to content

Make similar with graded axes more generic #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Make similar with graded axes more generic #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5acb295
Make `similar` with graded axes more generic
mtfishman Feb 13, 2025
4c08848
Add tests
mtfishman Feb 13, 2025
37a1171
Bump version
mtfishman Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "BlockSparseArrays"
uuid = "2c9a651f-6452-4ace-a6ac-809f4280fbb4"
authors = ["ITensor developers <[email protected]> and contributors"]
version = "0.2.17"
version = "0.2.18"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
6 changes: 2 additions & 4 deletions ext/BlockSparseArraysGradedUnitRangesExt/BlockSparseArraysGradedUnitRangesExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module BlockSparseArraysGradedUnitRangesExt

using BlockSparseArrays: AnyAbstractBlockSparseArray, BlockSparseArray, blocktype
using GradedUnitRanges: AbstractGradedUnitRange
using TypeParameterAccessors: set_eltype, set_ndims, unwrap_array_type
using TypeParameterAccessors: similartype, unwrap_array_type

# A block spare array similar to the input (dense) array.
# TODO: Make `BlockSparseArrays.blocksparse_similar` more general and use that,
Expand All @@ -15,9 +15,7 @@ function similar_blocksparse(
# TODO: Probably need to unwrap the type of `a` in certain cases
# to make a proper block type.
return BlockSparseArray{
elt,
length(axes),
set_eltype(set_ndims(unwrap_array_type(blocktype(a)), length(axes)), elt),
elt,length(axes),similartype(unwrap_array_type(blocktype(a)), elt, axes)
}(
axes
)
Expand Down
15 changes: 15 additions & 0 deletions test/test_gradedunitrangesext.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,21 @@ const elts = (Float32, Float64, Complex{Float32}, Complex{Float64})
@test b[Block(1)] == a1
@test iszero(b[Block(2)])
@test all(GradedUnitRanges.space_isequal.(axes(b), (r,)))

# Regression test for BitArray
r = gradedrange([U1(0) => 2, U1(1) => 3])
a1 = trues(2, 2)
a2 = trues(3, 3)
a = cat(a1, a2; dims=(1, 2))
b = a[r, dual(r)]
@test eltype(b) === Bool
@test b isa BlockSparseMatrix{Bool}
@test blockstoredlength(b) == 2
@test b[Block(1, 1)] == a1
@test iszero(b[Block(2, 1)])
@test iszero(b[Block(1, 2)])
@test b[Block(2, 2)] == a2
@test all(GradedUnitRanges.space_isequal.(axes(b), (r, dual(r))))
end
end
end
Loading