-
Notifications
You must be signed in to change notification settings - Fork 21
Use default link tags in movesites
#137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 90.26% 90.27%
=======================================
Files 54 54
Lines 3575 3577 +2
=======================================
+ Hits 3227 3229 +2
Misses 348 348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The |
|
Thanks @VinceNeede, can you change this line: Line 4 in 03520b6
version = "0.3.17" so we can register it in a new version of the package?
|
|
Removed the type restriction on tags and changed the documentation, and bumped to 0.3.17 |
|
The format check failed because we just updated the version of the formatter we are using, I'm fixing the formatting separately in #138 and then I'll update this PR accordingly. |
Description
The constructor for
AbstractMPSsubtypes now accepts a vector of tags as keyword to be used during the factorization. This is then used bysetindex!(::MPST, ::ITensor, ::UnitRange)to set the proper inds tags. This fixes #104 Issue, improving readability.Fixes #104
If practical and applicable, please include a minimal demonstration of the previous behavior and new behavior below.
Minimal demonstration of previous behavior
Output
MPS
[1] ((dim=2|id=834|"Qubit,Site,n=2"), (dim=2|id=590|"Link,n=1"))
[2] ((dim=2|id=590|"Link,n=1"), (dim=2|id=502|"Qubit,Site,n=3"), (dim=2|id=864|"Link,n=1"))
[3] ((dim=2|id=864|"Link,n=1"), (dim=2|id=138|"Qubit,Site,n=1"))
Minimal demonstration of new behavior
New Output
MPS
[1] ((dim=2|id=384|"Qubit,Site,n=2"), (dim=2|id=128|"Link,l=1"))
[2] ((dim=2|id=128|"Link,l=1"), (dim=2|id=986|"Qubit,Site,n=3"), (dim=2|id=66|"Link,l=2"))
[3] ((dim=2|id=66|"Link,l=2"), (dim=2|id=375|"Qubit,Site,n=1"))
How Has This Been Tested?
Please add tests that verify your changes to a file in the
testdirectory.Please give a summary of the tests that you added to verify your changes.
ITensorMPS.hasdefaultlinktagsreturns trueChecklist:
using JuliaFormatter; format(".")in the base directory of the repository (~/.julia/dev/ITensorMPS) to format your code according to our style guidelines.