Make the AbstractBeliefPropagationCache a subtype of the AbstractITensorNetwork
#236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
reviewed
May 9, 2025
mtfishman
reviewed
May 10, 2025
Co-authored-by: Matt Fishman <[email protected]>
Co-authored-by: Matt Fishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
AbstractBeliefPropagationCache <: AbstractITensorNetworkso that functionality defined on that type can be utilized.Specifically it allows accession of the tensors in the tensor network inside a
bpc::AbstractBeliefPropagationCacheviabps[v]and operations that were previously forwarded onto the network to immediately work (finding indices etc). Extra tests are added intest/test_beliefpropagation.jl.Setting of the tensors inside the cache via
bpc[v] = some_itensoris disabled just to the fact it may affect partitioning and message tensor information. Currently aset_index_preserve_graphversion is supported, although maybe this should be changed toset_index_preserve_graph_and_messagesso it is explicit to the user what they are doing.Most importantly, this PR will allow us to more naturally use the
BeliefPropagationCacherepresenting say<x|A|y>inProblemtypes inNetworkSolverswithout also requiring a separate copy of the state (|x>) to be passed around which is what the current implementation does.