Small Fixes #245
Merged
Small Fixes #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
reviewed
Jul 21, 2025
Co-authored-by: Matt Fishman <[email protected]>
mtfishman
reviewed
Jul 21, 2025
mtfishman
reviewed
Jul 21, 2025
Co-authored-by: Matt Fishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small error in the
delete_message(bpc::AbstractBeliefPropagationCache, pe::PartitionEdge)function where the input was vectorized but passed todelete_messageagain and notdelete_messages.Additionally, type restrictions have been put on first argument (the gate) to the
applyfunctions inapply.jlto avoid ambiguity issues when defining newapplyfunctions.