Fix bug with length 1 AbstractNetworkIterator types not executing their only compute! call.
#262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 28, 2025 10:37
…their single `compute!` call
…ives `BoundsError`. Constructing `RegionIterator` of length 0 is now undefined. Adjust region iterator `BoundsError` message to align with `SweepIterator`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking of
islaststepis now skipped for the first iteration. This fixes a bug where length 1 iterators don't iterate at all and thus don't execute their only call tocompute!.Skipping
islaststepcheck for the initial iterations makes sense as the interface ofAbstractNetworkIteratorassumes an implicit "move to first state" at construction.This also means that constructing a
AbstractNetworkIteratoris basically undefined as there is in that case there is no first state to move to. As such, constructingSweepIteratorandRegionIteratornow throws an error if if empty iterators are passed.I have added some tests for these edge cases; all other tests pass.