[NestedPermutedDimsArrays] Fix setindex!
#1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of
setindex!wasn't inverting the permutation, this fixes that issue. I also changed the tests to catch that issue, the previous version didn't catch it since the permutation was its own inverse.Additionally, I added some comments about how the
NestedPermutedDimsArraysmodule could be rewritten using aPermutedDimsArraywrapping aMappedArrays.MappedArray, as mentioned in ITensor/BlockSparseArrays.jl#2. I tried it out and it mostly works but there would be a few issues to work through with that approach, probably best to keep it on the back burner for now and reassess later.