[NDTensors] Downgrade GPUArraysCore to v0.1 #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting to learn about these changes in the GPU ecosystem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of changes going on in the GPU backends recently. GPUArrays.jl, which provides common GPU array functionality that is shared by CUDA.jl, AMDGPU.jl, Metal.jl, etc., recently transitioned to depending on KernelAbstractions.jl for writing native Julia code that gets cross-compiled across different GPU backends. Very cool stuff! However, that change seems to have broken a few things in our tests which we need to investigate, in the meantime I'll downgrade to a version before that transition and try things out again once the dust settles.