[ITensors] Define Sy for tJ site type #1642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added an Sy operator for the tJ site types
mtfishman
reviewed
Apr 4, 2025
|
Thanks @andrewkhardy, can you also add a test? |
|
@mtfishman Thanks for the quick response. Sorry, I'm new to this, what would be a helpful test? I didn't see anything immediately relevant in test_fermions.jl? |
Matt's tidyin suggestion Co-authored-by: Matt Fishman <[email protected]>
|
You could add something similar to the test of |
Adding a test for Sy to match Sx to insure the right Pauli operator is being applied to tJ site types.
|
Thanks for pointing that out, added! |
mtfishman
reviewed
Apr 7, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an Sy operator for the tJ site types. It should model the Sx operator form almost exactly.