-
Notifications
You must be signed in to change notification settings - Fork 128
Fix sqrt decomp #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sqrt decomp #1669
Conversation
Co-authored-by: Matt Fishman <[email protected]>
|
Can you bump the package version as well, and also add a test? |
|
Test failures are unrelated, looks like it is hitting a known bug in the cuTENSOR backend: JuliaGPU/CUDA.jl#2881. |
|
Sure, I bumped the Project.toml and added a test in |
|
@mtfishman I thought adding |
|
It's a bit confusing, the tests themselves use |
A quick fix is implemented to preserve the ITensor type in the
sqrt_decompfunction and allow it to work on GPUs.