Skip to content

Conversation

@JoeyT1994
Copy link
Contributor

A quick fix is implemented to preserve the ITensor type in the sqrt_decomp function and allow it to work on GPUs.

@mtfishman
Copy link
Member

Can you bump the package version as well, and also add a test?

@mtfishman
Copy link
Member

Test failures are unrelated, looks like it is hitting a known bug in the cuTENSOR backend: JuliaGPU/CUDA.jl#2881.

@JoeyT1994
Copy link
Contributor Author

Sure, I bumped the Project.toml and added a test in test_svd when calling factorize_svd with orthe = "none" which contains a call down to sqrt_decomp

@JoeyT1994
Copy link
Contributor Author

@mtfishman I thought adding using Adapt to the .toml for the tests would fix the failing test but it doesn't seem to, not sure where it needs to be loaded?

@mtfishman
Copy link
Member

It's a bit confusing, the tests themselves use test/Project.toml so you should also add it there (test/base/Project.toml is helpful for locally testing just the tests in test/base).

@mtfishman mtfishman merged commit 885175c into ITensor:main Sep 11, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants