Skip to content

Fix sqrt decomp #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 11, 2025
Merged

Fix sqrt decomp #1669

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
98f4572
Fix sqrt decomp
JoeyT1994 Sep 9, 2025
3e2c454
Update src/tensor_operations/matrix_decomposition.jl
JoeyT1994 Sep 9, 2025
16ec2c7
Test and version update
JoeyT1994 Sep 9, 2025
6145a49
Merge branch 'main' of github.com:JoeyT1994/ITensors.jl
JoeyT1994 Sep 9, 2025
8c4ea78
Run over array types
JoeyT1994 Sep 11, 2025
9b71bd4
Add adapt to base tests toml
JoeyT1994 Sep 11, 2025
ea07aba
Update test project toml too
JoeyT1994 Sep 11, 2025
53ae382
Also JL Arrays
JoeyT1994 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tensor_operations/matrix_decomposition.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,8 +581,8 @@ using NDTensors: map_diag!
function sqrt_decomp(D::ITensor, u::Index, v::Index)
(storage(D) isa Union{Diag,DiagBlockSparse}) ||
error("Must be a diagonal matrix ITensor.")
sqrtDL = diag_itensor(u, dag(u)')
sqrtDR = diag_itensor(v, dag(v)')
sqrtDL = adapt(datatype(D))(diag_itensor(u, dag(u)'))
sqrtDR = adapt(datatype(D))(diag_itensor(v, dag(v)'))
map_diag!(sqrt ∘ abs, sqrtDL, D)
map_diag!(sqrt ∘ abs, sqrtDR, D)
δᵤᵥ = copy(D)
Expand Down
Loading