[NDTensors] Vendor TypeParameterAccessors.jl #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1657 and #1674. The idea here is that I don't want to upgrade NDTensors.jl to TypeParameterAccessors.jl v0.4 since it is too annoying to do, but the ITensorBase.jl ecosystem uses TypeParameterAccessors.jl v0.4, and I don't want the compat requirements to conflict if ITensors.jl and ITensorBase.jl are loaded together, so I vendor TypeParameterAccessors.jl v0.3 into this library (i.e. copy it into this codebase directly instead of loading it through the package manager) so it can use its own private version of that codebase.
The vendoring script and strategy is based on https://github.com/JuliaTesting/ExplicitImports.jl/tree/v1.13.2/vendor.
To-do:
NDTensors/vendor/run.jlshould replaceusing TypeParametersAccessorswithusing NDTensors.Vendored.TypeParameterAccessors.