Skip to content

[NDTensors] Define denseblocks on Dense #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

[NDTensors] Define denseblocks on Dense #1677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NDTensors/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "NDTensors"
uuid = "23ae76d9-e61a-49c4-8f12-3f1a16adf9cf"
authors = ["Matthew Fishman <[email protected]>"]
version = "0.4.14"
version = "0.4.15"

[deps]
Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"
Expand Down
2 changes: 2 additions & 0 deletions NDTensors/src/dense/densetensor.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ end
# Useful for using Base Array functions
array(T::DenseTensor) = convert(Array, T)

denseblocks(T::DenseTensor) = T

function diagview(T::DenseTensor)
return diagview(array(T))
end
Expand Down
4 changes: 4 additions & 0 deletions NDTensors/test/test_dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
@eval module $(gensym())
using NDTensors
using NDTensors: denseblocks
using NDTensors.MetalExtensions: mtl
using Test: @testset, @test, @test_throws, @test_broken
using GPUArraysCore: @allowscalar
Expand Down Expand Up @@ -30,6 +31,9 @@ NDTensors.dim(i::MyInd) = i.dim
@test dims(A[2:3, 2:end]) == (2, 3)
@test dims(A[3, 2:end]) == (3,)

@test dense(A) ≡ A
@test denseblocks(A) ≡ A

randn!(A)

@test ndims(A) == 2
Expand Down
Loading