Skip to content

Commit e1a89ac

Browse files
committed
Use permuteddims
1 parent aede4cd commit e1a89ac

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ KroneckerArraysTensorProductsExt = "TensorProducts"
2727
Adapt = "4.3"
2828
BlockArrays = "1.6"
2929
BlockSparseArrays = "0.9"
30-
DerivableInterfaces = "0.5"
30+
DerivableInterfaces = "0.5.3"
3131
DiagonalArrays = "0.3.11"
3232
FillArrays = "1.13"
3333
GPUArraysCore = "0.2"

src/fillarrays/kroneckerarray.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ function _copyto!!(dest::Delta{<:Any,N}, src::Delta{<:Any,N}) where {N}
9696
return dest
9797
end
9898

99-
# TODO: Define `DerivableInterfaces.permuteddims` and overload that instead.
100-
function Base.PermutedDimsArray(a::Delta, perm)
99+
using DerivableInterfaces: DerivableInterfaces, permuteddims
100+
function DerivableInterfaces.permuteddims(a::Delta, perm)
101101
ax_perm = Base.PermutedDimsArrays.genperm(axes(a), perm)
102102
return Delta{eltype(a)}(ax_perm)
103103
end

src/kroneckerarray.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,9 @@ function _permutedims!!(dest::AbstractArray, src::AbstractArray, perm)
132132
return dest
133133
end
134134

135-
# TODO: Define `DerivableInterfaces.permuteddims` and overload that instead.
136-
function Base.PermutedDimsArray(a::KroneckerArray, perm)
137-
return PermutedDimsArray(arg1(a), perm) PermutedDimsArray(arg2(a), perm)
135+
using DerivableInterfaces: DerivableInterfaces, permuteddims
136+
function DerivableInterfaces.permuteddims(a::KroneckerArray, perm)
137+
return permuteddims(arg1(a), perm) permuteddims(arg2(a), perm)
138138
end
139139

140140
function Base.permutedims!(dest::KroneckerArray, src::KroneckerArray, perm)

0 commit comments

Comments
 (0)