Skip to content

Conversation

@mtfishman
Copy link
Member

@mtfishman mtfishman commented Apr 1, 2025

This makes use of the tensor factorizations @lkdvos added in ITensor/TensorAlgebra.jl#36 that are based on MatrixAlgebraKit.jl, and implicitly includes support for truncated SVD and eigendecomposition since the keyword arguments are forwarded to MatrixAlgebraKit.jl.

To-do:

  • Add left_null and right_null.
  • Add tests.

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 65.55556% with 31 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (3249398) to head (40c678e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tensoralgebra.jl 65.55% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   73.14%   72.07%   -1.08%     
==========================================
  Files          15       15              
  Lines         741      820      +79     
==========================================
+ Hits          542      591      +49     
- Misses        199      229      +30     
Flag Coverage Δ
docs 27.90% <0.00%> (-2.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman marked this pull request as draft April 1, 2025 23:54
@mtfishman mtfishman changed the title [WIP] Add more factorizations Add more factorizations Apr 3, 2025
@mtfishman mtfishman marked this pull request as ready for review April 3, 2025 20:42
@mtfishman mtfishman merged commit d2d7be9 into main Apr 3, 2025
12 of 14 checks passed
@mtfishman mtfishman deleted the more_factorizations branch April 3, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant