Skip to content

Define orth and polar #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Define orth and polar #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a9cbc4
Define orth and polar
mtfishman Apr 8, 2025
6818241
Bump version
mtfishman Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "NamedDimsArrays"
uuid = "60cbd0c0-df58-4cb7-918c-6f5607b73fde"
authors = ["ITensor developers <[email protected]> and contributors"]
version = "0.6.2"
version = "0.6.3"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down Expand Up @@ -36,6 +36,6 @@ LinearAlgebra = "1.10"
MapBroadcast = "0.1.6"
Random = "1.10"
SimpleTraits = "0.9.4"
TensorAlgebra = "0.2.9"
TensorAlgebra = "0.2.10"
TypeParameterAccessors = "0.2, 0.3"
julia = "1.10"
6 changes: 5 additions & 1 deletion src/tensoralgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ using TensorAlgebra:
left_orth,
left_polar,
lq,
orth,
permmortar,
polar,
qr,
right_null,
right_orth,
Expand Down Expand Up @@ -162,7 +164,9 @@ function factorize_with(f, a::AbstractNamedDimsArray, dimnames_codomain; kwargs.
return factorize_with(f, a, codomain, domain; kwargs...)
end

for f in [:qr, :lq, :left_polar, :right_polar, :left_orth, :right_orth, :factorize]
for f in [
:factorize, :left_orth, :left_polar, :lq, :orth, :polar, :qr, :right_orth, :right_polar
]
@eval begin
function TensorAlgebra.$f(
a::AbstractNamedDimsArray, dimnames_codomain, dimnames_domain; kwargs...
Expand Down
21 changes: 13 additions & 8 deletions test/test_tensoralgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
using LinearAlgebra: factorize, lq, norm, qr, svd
using NamedDimsArrays:
dename,
using NamedDimsArrays: dename, nameddimsindices, namedoneto
using TensorAlgebra:
TensorAlgebra,
contract,
fusedims,
left_null,
left_orth,
left_polar,
nameddimsindices,
namedoneto,
orth,
polar,
right_null,
right_orth,
right_polar
using TensorAlgebra: TensorAlgebra, contract, fusedims, splitdims
right_polar,
splitdims
using Test: @test, @testset, @test_broken
elts = (Float32, Float64, Complex{Float32}, Complex{Float64})
@testset "TensorAlgebra (eltype=$(elt))" for elt in elts
Expand Down Expand Up @@ -59,14 +62,16 @@ elts = (Float32, Float64, Complex{Float32}, Complex{Float64})
a = randn(elt, i, j)
# TODO: Should this be allowed?
# TODO: Add support for specifying new name.
for f in (qr, lq, left_polar, right_polar, left_orth, right_orth, factorize)
for f in
(factorize, left_orth, left_polar, lq, orth, polar, qr, right_orth, right_polar)
x, y = f(a, (i,))
@test x * y ≈ a
end

a = randn(elt, i, j, k, l)
# TODO: Add support for specifying new name.
for f in (qr, lq, left_polar, right_polar, left_orth, right_orth, factorize)
for f in
(factorize, left_orth, left_polar, lq, orth, polar, qr, right_orth, right_polar)
x, y = f(a, (i, k), (j, l))
@test x * y ≈ a
end
Expand Down
Loading