Improve subgraph from QuotientVertex and other small improvements#113
Merged
Improve subgraph from QuotientVertex and other small improvements#113
subgraph from QuotientVertex and other small improvements#113Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 85.66% 85.53% -0.13%
==========================================
Files 54 54
Lines 1765 1777 +12
==========================================
+ Hits 1512 1520 +8
- Misses 253 257 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR,
subgraph(g, QuotientVertex(v))now outputs an unpartitioned graph, while before forPartitionedGraphit output aPartitionedGraphwith one partition.Additionally, this makes a small fix to
has_edgewhen the edge involves vertices that aren't in the vertex list of the graph, and also some small improvements to minimize ambiguities when overloading the interface.This all helps with getting ITensor/ITensorNetworks.jl#264 merged.