Skip to content

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Jan 13, 2025

This PR extends the sparse interface functions for LinearAlgebra.Diagonal, along with some basic tests.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.13%. Comparing base (aceca8c) to head (b6ccf93).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/wrappers.jl 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   65.53%   63.13%   -2.40%     
==========================================
  Files           6        6              
  Lines         264      274      +10     
==========================================
  Hits          173      173              
- Misses         91      101      +10     
Flag Coverage Δ
docs 63.00% <0.00%> (-2.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member

Great, thanks!

@mtfishman mtfishman assigned mtfishman and unassigned mtfishman Jan 13, 2025
@mtfishman mtfishman self-requested a review January 13, 2025 17:33
@lkdvos
Copy link
Contributor Author

lkdvos commented Jan 13, 2025

(I still can't merge this)

@mtfishman
Copy link
Member

(I still can't merge this)

Ah, that's annoying, we'll have to look into giving you merge rights. I'll merge in the meantime.

@mtfishman mtfishman merged commit 68399d6 into ITensor:main Jan 13, 2025
9 of 11 checks passed
@lkdvos lkdvos deleted the diagonal branch January 13, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants