Skip to content

Test BlockSparseArrays #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Test BlockSparseArrays #29

merged 7 commits into from
Feb 19, 2025

Conversation

ogauthe
Copy link
Collaborator

@ogauthe ogauthe commented Feb 13, 2025

This PR uncomments a test file testing BlockSparseArrays integration in TensorAlgebra.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.95%. Comparing base (2da8e63) to head (26f582b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   93.92%   93.95%   +0.03%     
==========================================
  Files          15       15              
  Lines         362      364       +2     
==========================================
+ Hits          340      342       +2     
  Misses         22       22              
Flag Coverage Δ
docs 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title test BlockSparseArrays Test BlockSparseArrays Feb 14, 2025
@mtfishman
Copy link
Member

Huh I don't see an issue in how the test is written so maybe it is hitting a bug in TensorAlgebra.contract...

@ogauthe
Copy link
Collaborator Author

ogauthe commented Feb 14, 2025

I am working on it and I am quite puzzled.

@ogauthe
Copy link
Collaborator Author

ogauthe commented Feb 14, 2025

With ITensor/BlockSparseArrays.jl#52, this test now passes.

@mtfishman
Copy link
Member

Thanks! Good to have more tests and functionality working.

@mtfishman mtfishman merged commit 9407722 into ITensor:main Feb 19, 2025
12 checks passed
@ogauthe ogauthe deleted the BlockSparseArrays branch February 19, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants