Skip to content

Conversation

ogauthe
Copy link
Collaborator

@ogauthe ogauthe commented Aug 4, 2025

As we discussed last week, there is a difficulty in contract to deal with both a given destination and a permutation for this destination. We settled on removing the label_dest argument such that the output is always returned without additional permutation. This PR removes label_dest everywhere in contract.

Locally my tests fail in test_matrixalgebra.jl for Truncation on ComplexFloat32. I did not change that part so I do not understand what is happening.
EDIT: CI is fine, so it must be my local config.

Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.04%. Comparing base (bd74481) to head (356deff).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/contract/blockedperms.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   94.90%   95.04%   +0.14%     
==========================================
  Files          14       14              
  Lines         451      444       -7     
==========================================
- Hits          428      422       -6     
+ Misses         23       22       -1     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogauthe
Copy link
Collaborator Author

ogauthe commented Aug 15, 2025

replaced by #75

@ogauthe ogauthe closed this Aug 15, 2025
@ogauthe ogauthe deleted the biperm_out branch September 3, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant