Closed
Conversation
giallu
force-pushed
the
giallu/port_to_cmake
branch
from
f7ff161 to
446e743
Compare
PrintFileName and SplitTime are compiled in the library only when TARGET_API_LIB is not defined, which is always defined in the cmake build. Apprently, those two symbols and DetectInputINChIFileType are only used in the inchi-1 executable, so they were moved in ichimain.c
giallu
force-pushed
the
giallu/port_to_cmake
branch
from
446e743 to
d14ae36
Compare
JanCBrammer
force-pushed
the
rwth
branch
4 times, most recently
from
921e8fa to
4f218c2
Compare
Closed
JanCBrammer
force-pushed
the
rwth
branch
5 times, most recently
from
1d99ad3 to
cfee545
Compare
JanCBrammer
force-pushed
the
rwth
branch
2 times, most recently
from
8be0c05 to
3d933ef
Compare
Contributor
Author
|
Superseded by #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits add support for building the library and demo programs with cmake. The current makefiles/visual studio project files are still there but not used anymore except to compile the reference library for tests.
Of course they can go away once the reference library will be one already built with cmake.
github actions scripts/workflow were also updated to use the new cmake build and regression validation scripts adapted to the out of tree build.