Skip to content

Lowered minSdk to 26 and add pre-Android 11 support#701

Open
sosauce wants to merge 3 commits intoIacobIonut01:mainfrom
sosauce:lower-minSDK
Open

Lowered minSdk to 26 and add pre-Android 11 support#701
sosauce wants to merge 3 commits intoIacobIonut01:mainfrom
sosauce:lower-minSDK

Conversation

@sosauce
Copy link

@sosauce sosauce commented Sep 6, 2025

hi, this PR adds minimum support for down to Android 8, I could only test on an emulator so user with real devices will need to confirm if it works or not

@IacobIonut01
Copy link
Owner

Did you check the trash feature?

@sosauce
Copy link
Author

sosauce commented Sep 6, 2025

yes, createTrashRequest just sets IS_TRASHED under the hood

@sosauce
Copy link
Author

sosauce commented Sep 6, 2025

unless its unavailable pre api 30, idk i did this at midnight ahah, in this case, trash will need to be disable all together, or create a local trash but idk if you wanna do that

@IacobIonut01
Copy link
Owner

unless its unavailable pre api 30, idk i did this at midnight ahah, in this case, trash will need to be disable all together, or create a local trash but idk if you wanna do that

Yeah it's unavailable pre api 30. That's why I didn't make it earlier, because I would want the trash to be available.

@sosauce
Copy link
Author

sosauce commented Sep 6, 2025

Okay, I'll do some adjustement, I know this is an important feature, but opening your app to more devices is probably more important. I'll look what I can do, if nothing, you'll have to decide if you create a local trash or don't support A11-

@sosauce
Copy link
Author

sosauce commented Sep 7, 2025

@IacobIonut01 Removed trash logic pre Android 11. It's now your choice if you implement your own trash or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants