Merged
Conversation
3f19dad to
7f53f51
Compare
Add a Close() method to allow graceful shutdown of the RedHub server. This addresses issue #14 and provides a similar API to tidwall/redcon. Changes: - Add mu, addr, and running fields to RedHub struct for server state - Add Close() method that gracefully shuts down the server - Modify ListenAndServe to track server state - Add unit tests for Close() functionality - Add integration test for Close() method The Close() method: - Returns error if server is not running - Calls gnet.Stop() to gracefully shutdown - Is thread-safe with mutex protection - Can be called from any goroutine Signed-off-by: BlockCraftsman <167502426+BlockCraftsman@users.noreply.github.com>
7f53f51 to
9aceb31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Close() method to allow graceful shutdown of the RedHub server. This addresses issue #14 and provides a similar API to tidwall/redcon.
Changes:
The Close() method: