notifications: drop Icinga 2 specific event types

[yhabteab]

As just discussed with @nilmerg about this, Icinga Notifications shouldn't be concerned with Icinga 2 specific event types like downtime or flapping anymore. These event types are specific to Icinga 2 and Icinga DB as a source should translate these into more generic event types mute and unmute respectively. This applies to acknowledgements as well, but since we don't have a direct mapping for those yet and Johannes wasn't entirely sure about that either, I'll leave those as-is for now.

[yhabteab]

Since these changes break the Icinga DB PR of you as it's making use of the just removed event types, I'll let you review this @oxzi.

[julianbrost]

Is this important in any way and if so, why? (I'm wondering why this is now coming up on short notice...)

[yhabteab]

Is this important in any way and if so, why?

It's not that important, but there won't be any special handling for these types in Notifications either. I didn't even knew that these types will be dropped from Icinga Notifications.

(I'm wondering why this is now coming up on short notice...)

Short notice? To my limited knowledge, this isn't something new but was already planned, and I've opened this as soon as I informed about it too. If you don't want that, then just ignore it, I don't mind.

[julianbrost]

I didn't even knew that these types will be dropped from Icinga Notifications.

Neither am I aware of any recent communication on this. So if there randomly appears a "As just discussed with @nilmerg" PR, that makes me wonder if that's another "that should be changed because Icinga Notifications Web needs that for whatever reason" change, but for that, it misses more explanation.

Icinga Notifications shouldn't be concerned with Icinga 2 specific event types like downtime or flapping anymore. These event types are specific to Icinga 2 and Icinga DB as a source should translate these into more generic event types mute and unmute respectively.

Yes and no. Icinga Notifications should not be overly specific on Icinga 2, but on the other hand, it's supposed to eventually be able to do what native Icinga 2 notifications can do at the moment, which includes being able to route these notification types differently. Thus, these different event types were included to have something that we could later build filters on.

That doesn't mean that this must be part of the main event type. So without a concrete reason why having these types is a problem now or with a better plan on how to do this, I don't see why we should change this now.