-
Notifications
You must be signed in to change notification settings - Fork 0
Introduce DB#InsertObtainID() function
#64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxzi
reviewed
Aug 15, 2024
2045ba4 to
1317301
Compare
oxzi
approved these changes
Apr 29, 2025
Member
oxzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR with Icinga Notifications after replacing util.InsertAndFetchId with this function in a branch based on #127. Thanks and sorry for the delay.
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Apr 29, 2025
With Icinga/icinga-go-library#64 and Icinga/icinga-go-library#127 being merged, the internal/utils package is moved to the IGL and can be removed here. This is another step to unify our Go codebase.
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Apr 30, 2025
With Icinga/icinga-go-library#64 and Icinga/icinga-go-library#127 being merged, the internal/utils package is moved to the IGL and can be removed here. This is another step to unify our Go codebase.
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
May 8, 2025
With Icinga/icinga-go-library#64 and Icinga/icinga-go-library#127 being merged, most of the internal/utils package is moved to the IGL and can be removed here. This is another step to unify our Go codebase.
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Jun 30, 2025
With Icinga/icinga-go-library#64 and Icinga/icinga-go-library#127 being merged, most of the internal/utils package is moved to the IGL and can be removed here. This is another step to unify our Go codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an auxiliary DB function for inserting and retrieving the last inserted ID with both the
PostreSQLandMySQLdrivers. Since the MySQL driver supports/providesLastInsertId()natively, there's nothing special that this function needs to do. On the other hand, PostgreSQL doesn't provide such functionality on its own, so you have to append a specialRETURNING idtext to the query you want to execute and scan the result into a given dest of your own.cherry-picked from #18