Skip to content

ContactGroupsController: Show add contact link if no contact exists#340

Merged
nilmerg merged 3 commits intomainfrom
feature/show-msg-when-no-contact-available
Oct 7, 2025
Merged

ContactGroupsController: Show add contact link if no contact exists#340
nilmerg merged 3 commits intomainfrom
feature/show-msg-when-no-contact-available

Conversation

@sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jun 23, 2025

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jun 23, 2025
@sukhwinder33445 sukhwinder33445 self-assigned this Jun 23, 2025
@sukhwinder33445
Copy link
Contributor Author

Case : There is only one contact available, and there is also a contact group containing this contact.

When the user deletes the contact, should the contactgroup also be deleted? Because the contact group now has no members and the modal Edit contact group again shows no suggestion (in contactgroup detail view).

@flourish86
Copy link
Contributor

It works great. But we should also handle the case, when the user has no channels either, shouldn't we?

In this case user won't be able to create a contact via the second column. I will come up with something soon …

@sukhwinder33445
Copy link
Contributor Author

We can display a kind of wizard when the user activates the module for the first time to show these steps (channel, contact). Same as the setup wizard in Icingaweb.

@flourish86
Copy link
Contributor

flourish86 commented Jul 1, 2025

I thought of something like this for the case when there's neither channels nor contacts configured. A wizard could be an additional feature to onboard user.

For the empty state warnings, there's still the use case, when channels or contacts are deleted in hindsight.

And another thing: The empty state statement still reads "No contacts found.", even for contact groups, it should be "No contact groups found."

Frame 70

In this example the user …

  1. opens channels in the second column
  2. save channel and closes the column
  3. then adds the contact
  4. saves and closes it
  5. can now create the contact group

@sukhwinder33445 sukhwinder33445 force-pushed the feature/show-msg-when-no-contact-available branch from bc29c37 to f3a7fcf Compare July 1, 2025 14:58
@sukhwinder33445 sukhwinder33445 force-pushed the feature/show-msg-when-no-contact-available branch 2 times, most recently from 2c7e6d5 to 0cd1d7c Compare September 15, 2025 07:13
@nilmerg nilmerg force-pushed the feature/show-msg-when-no-contact-available branch from 0cd1d7c to e3a59d9 Compare October 7, 2025 12:36
@nilmerg
Copy link
Member

nilmerg commented Oct 7, 2025

When the user deletes the contact, should the contactgroup also be deleted? Because the contact group now has no members and the modal Edit contact group again shows no suggestion (in contactgroup detail view).

No, the contactgroup form does not require to define any members and the daemon handles empty groups as well.

@nilmerg nilmerg force-pushed the feature/show-msg-when-no-contact-available branch 2 times, most recently from 986485d to eb5d3c6 Compare October 7, 2025 14:29
sukhwinder33445 and others added 3 commits October 7, 2025 16:30
- ContactsContoller: Closing the container is sufficient.
Without channels, most of the configuration is not possible.
Technically, channels are not required for groups, but we
want to guide new users to the channel configuration because
of its importance. Once there is a channel, groups can be
created but we still hint that there are no contacts yet.
@nilmerg nilmerg force-pushed the feature/show-msg-when-no-contact-available branch from eb5d3c6 to 987224f Compare October 7, 2025 14:30
@nilmerg nilmerg merged commit a9cb565 into main Oct 7, 2025
10 checks passed
@nilmerg nilmerg deleted the feature/show-msg-when-no-contact-available branch October 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contact Groups: Prevent users from trying to create a contact group, when there are no contacts

3 participants